Repository navigation
Fix formatter's processChildNodes - #48921
Merged
Nathan Shively-Sanders (sandersn) merged 1 commit intoMay 2, 2022
Merged
Conversation
processChildNodes needs to skip processing when the node array is outside the target range, just like processChildNode already does for a single node. Fixes #48006
Nathan Shively-Sanders (sandersn)
requested a review
from Gabriela Araujo Britto (gabritto)
May 2, 2022 19:22
TypeScript Bot (typescript-bot)
added
Author: Team
For Milestone Bug
Nathan Shively-Sanders (sandersn)
assigned
Andrew Branch (andrewbranch) and unassigned
Nathan Shively-Sanders (sandersn)
Nathan Shively-Sanders (sandersn)
requested a review
from Andrew Branch (andrewbranch)
May 2, 2022 19:22
Sheetal Nandi (sheetalkamat)
approved these changes
May 2, 2022
Andrew Branch (andrewbranch)
approved these changes
May 2, 2022
Nathan Shively-Sanders (sandersn)
deleted the
fix-formatter-processChildNodes
branch
May 2, 2022 19:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
processChildNodes needs to skip processing when the node array is outside the target range, just like processChildNode already does for a single node.
The new code is copied from processChildNode and
skipToEndOfchanges to allowNode | NodeArray.Fixes #48006